-
Notifications
You must be signed in to change notification settings - Fork 129
8372304: [lworld] Test serviceability/jvmti/valhalla/HeapDump/HeapDump.java fails in product build #1754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: lworld
Are you sure you want to change the base?
Conversation
|
👋 Welcome back amenkov! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
/issue 8372304 |
|
@alexmenkov This issue is referenced in the PR title - it will now be updated. |
|
/touch |
|
@alexmenkov The pull request is being re-evaluated and the inactivity timeout has been reset. |
|
/touch |
|
@alexmenkov The pull request is being re-evaluated and the inactivity timeout has been reset. |
|
/issue JDK-8372304 |
|
@alexmenkov This issue is referenced in the PR title - it will now be updated. |
|
/touch |
|
@alexmenkov The pull request is being re-evaluated and the inactivity timeout has been reset. |
|
/issue 8372304 |
|
@alexmenkov This issue is referenced in the PR title - it will now be updated. |
The test executes subprocess with
-XX:+PrintInlineLayoutand-XX:+PrintFlatArrayLayoutarguments. These are diagnostic arguments, require-XX:+UnlockDiagnosticVMOptionsto unlock.Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1754/head:pull/1754$ git checkout pull/1754Update a local copy of the PR:
$ git checkout pull/1754$ git pull https://git.openjdk.org/valhalla.git pull/1754/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1754View PR using the GUI difftool:
$ git pr show -t 1754Using diff file
Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1754.diff
Using Webrev
Link to Webrev Comment